Emit error when manager model argument is incorrect #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Model won't define a manager if manager model argument doesn't match model - Creating a dynamic manager where manager model argument doesn't match queryset model argument will now emit an error - Manager type created via `.from_queryset` will now populate its model argument (as long as it's correct)
flaeppe
force-pushed
the
fix/fail-manager-model-arg-mismatch
branch
from
bf28a17 to
926daf5
Compare
flaeppe
force-pushed
the
fix/fail-manager-model-arg-mismatch
branch
from
926daf5 to
ea47c0c
Compare
flaeppe
force-pushed
the
fix/type-queryset-as-manager
branch
from
d927b96 to
29b5c5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.from_querysetwill now populate its model argument (as long as it's correct)Related issues
typeddjango#1025 (comment)